-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include DEA's new offshore territories tag #335
Conversation
Needed for our GQA masking
We were only allowing latter ones to be None.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #335 +/- ##
===========================================
+ Coverage 84.37% 84.44% +0.06%
===========================================
Files 26 26
Lines 4506 4506
===========================================
+ Hits 3802 3805 +3
+ Misses 704 701 -3 ☔ View full report in Codecov by Sentry. |
(The Docker Push action is failing for an unrelated reason — missing dockerhub credentials. I'm not an repo admin so can't view/setup credentials #336) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
... and add a test case of a modern wagl output.
The added test data found a bug unrelated to the offshore territories: when the first measurement has no explicit CRS it fails with a reference error.
I've also unwisely included a few housekeeping commits here.
-Pre-commit bump